React-native: Include the NativeAnimation module on iOS in the starter project
https://github.com/facebook/react-native/tree/master/Libraries/NativeAnimation should be included when creating a new project. We will want to use native animations in react-native core so having it included by default makes sense. It is also included by default on Android now.
janicduplessis
All 2 comments
I'm new to the codebase and would like to take this on if that's alright. I looked around and couldn't find where this logic lives. Perhaps if you have a minute, can you point out where/how it is included on Android? Also, some steps to test expected behavior. Should there be an automated test? Thanks!!
petrgazarov
on 7 Nov 2016
@janicduplessis I've made a pull request here. I added the ../node_modules/react-native/Libraries/NativeAnimation/RCTAnimation.xcodeproj file and linked libRCTAnimation.a, in local-cli/generator-ios/templates/xcodeproj/project.pbxproj.
Do let me know if everything is OK. I published my branch in Sinopia and tried having useNativeDriver. No errors. Animation works. Thank you.
sreejithr
on 7 Nov 2016
Related issues
despairblue
·
3Comments
axelg12
·
3Comments
vikeri
·
3Comments
lazywei
·
3Comments
jlongster
·
3Comments
Most helpful comment
@janicduplessis I've made a pull request here. I added the
../node_modules/react-native/Libraries/NativeAnimation/RCTAnimation.xcodeprojfile and linkedlibRCTAnimation.a, inlocal-cli/generator-ios/templates/xcodeproj/project.pbxproj.Do let me know if everything is OK. I published my branch in Sinopia and tried having
useNativeDriver. No errors. Animation works. Thank you.