Yarn: Static predicate field names are inconsistent
There isn't a consistent name scheme for static predicate fields. We should decide on one of these formats:
- No prefix or suffix:
RIDERS - 'Is' or 'can' prefix only:
IS_FOOD - 'Predicate' suffix:
AIR_PREDICATE - 'Is' or 'can' prefix and 'predicate' suffix:
IS_AIR_PREDICATE - 'Checker' suffix:
DOOR_BREAK_DIFFICULTY_CHECKER - 'Is' or 'can' prefix and 'checker' suffix:
IS_DOOR_BREAK_DIFFICULTY_CHECKER - 'Filter' suffix:
BLOW_UP_FILTER - 'Is' or 'can' prefix and 'filter' suffix:
IS_BLOW_UP_FILTER - Just predicate:
PREDICATE
haykam821
All 8 comments
I prefer only FILTER/CHECKER suffix without IS prefix.
liach
on 28 Jul 2020
I would prefer PREDICATE suffix without IS prefix
YanisBft
on 29 Jul 2020
Imo a predicate is a function, so IS_FOOD makes the most sense to me, and fits with the style I tend to go with in my personal code.
Earthcomputer
on 17 Aug 2020
I also prefer IS_FOOD or IS_FOOD_PREDICATE
TheBrokenRail
on 18 Aug 2020
Yes, I also prefer the IS_ suffix. More generally I think we should name Predicates and Functions as if they were methods.
Runemoro
on 19 Aug 2020
Yes, I also prefer the IS_ suffix.
liach
on 19 Aug 2020
'Is' or 'can' prefix only: IS_FOOD
I vote for IS_ prefix only. It's just the most concise.
Sollace
on 9 Apr 2021
looking back, now i support is prefix. or we can alternatively have a 3rd person present tense verb, like HAS_EFFECT, REQUIRES_SOME_PERMISSION, etc.
liach
on 10 Apr 2021
Related issues
Sollace
·
12Comments
jamierocks
·
13Comments
darkevilmac
·
14Comments
asiekierka
·
23Comments
Boundarybreaker
·
11Comments
Most helpful comment
Imo a predicate is a function, so
IS_FOODmakes the most sense to me, and fits with the style I tend to go with in my personal code.